[Mesa-dev] [PATCH] i965: Fix move_interpolation_to_top() pass.

Matt Turner mattst88 at gmail.com
Tue Jul 26 21:12:47 UTC 2016

On Tue, Jul 26, 2016 at 1:19 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> The pass I introduced in commit a2dc11a7818c04d8dc0324e8fcba98d60bae
> was entirely broken.  A missing "break" made the load_interpolated_input
> case always fall through to "default" and hit a "continue", making it
> not actually move any load_interpolated_input intrinsics at all.

Let's make a rule that non-obvious fallthroughs *must* be marked with
a /* fallthrough */ comment. That would have lead reviewers to notice
that something was strange. Coverity also makes noise about this, and
that would be nice to avoid as well.

More information about the mesa-dev mailing list