[Mesa-dev] [PATCH] i965: Fix move_interpolation_to_top() pass.
kenneth at whitecape.org
Tue Jul 26 21:56:35 UTC 2016
On Tuesday, July 26, 2016 2:12:47 PM PDT Matt Turner wrote:
> On Tue, Jul 26, 2016 at 1:19 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> > The pass I introduced in commit a2dc11a7818c04d8dc0324e8fcba98d60bae
> > was entirely broken. A missing "break" made the load_interpolated_input
> > case always fall through to "default" and hit a "continue", making it
> > not actually move any load_interpolated_input intrinsics at all.
> Let's make a rule that non-obvious fallthroughs *must* be marked with
> a /* fallthrough */ comment. That would have lead reviewers to notice
> that something was strange. Coverity also makes noise about this, and
> that would be nice to avoid as well.
I think that's a good idea, but I doubt it would have helped in this
case. (Given that we didn't notice a missing break, I don't think we
would've noticed a missing /* fallthrough */ either...)
Coverity likely caught this, but I haven't gotten a "New Defects" email
about it yet. I'm guessing Jenkins just spotted the IVB hangs before
Coverity's periodic email got sent out...
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: This is a digitally signed message part.
More information about the mesa-dev