[Mesa-dev] [PATCH 6/6] isl: automake: use VISIBILITY_CFLAGS to restrict symbol visibility

Jason Ekstrand jason at jlekstrand.net
Wed Jul 27 15:22:35 UTC 2016


Thanks. Came across some interesting issues with Talos the other day with
Talos having both my system Mesa and a branch of the Vulkan driver at the
same time.  Bad things happened because my debug branch of the Vulkan
driver was picking up isl symbols from system Mesa.  Regardless of what we
do with the others, this one should be cc'd to stable.

On Jul 27, 2016 6:03 AM, "Emil Velikov" <emil.l.velikov at gmail.com> wrote:

> From: Emil Velikov <emil.velikov at collabora.com>
>
> Cc: "12.0" <mesa-stable at lists.freedesktop.org>
> Cc: Jason Ekstrand <jason at jlekstrand.net>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  src/intel/isl/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/intel/isl/Makefile.am b/src/intel/isl/Makefile.am
> index 7c22324..1b1a357 100644
> --- a/src/intel/isl/Makefile.am
> +++ b/src/intel/isl/Makefile.am
> @@ -35,6 +35,7 @@ noinst_LTLIBRARIES = $(ISL_GEN_LIBS) libisl.la
>
>  # The gallium includes are for the util/u_math.h include from
> main/macros.h
>  AM_CPPFLAGS = \
> +       $(VISIBILITY_CFLAGS) \
>         $(INTEL_CFLAGS) \
>         $(VALGRIND_CFLAGS) \
>         $(DEFINES) \
> --
> 2.9.0
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160727/0f43a1bc/attachment.html>


More information about the mesa-dev mailing list