[Mesa-dev] [PATCH 6/6] isl: automake: use VISIBILITY_CFLAGS to restrict symbol visibility

[Kenneth Graunke]

On Wednesday, July 27, 2016 2:02:55 PM PDT Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Cc: "12.0" <mesa-stable at lists.freedesktop.org>
> Cc: Jason Ekstrand <jason at jlekstrand.net>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  src/intel/isl/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/intel/isl/Makefile.am b/src/intel/isl/Makefile.am
> index 7c22324..1b1a357 100644
> --- a/src/intel/isl/Makefile.am
> +++ b/src/intel/isl/Makefile.am
> @@ -35,6 +35,7 @@ noinst_LTLIBRARIES = $(ISL_GEN_LIBS) libisl.la
>  
>  # The gallium includes are for the util/u_math.h include from main/macros.h
>  AM_CPPFLAGS = \
> +	$(VISIBILITY_CFLAGS) \
>  	$(INTEL_CFLAGS) \
>  	$(VALGRIND_CFLAGS) \
>  	$(DEFINES) \
> 

I actually wrote a similar patch a couple days ago, and gave it to Jason
to see if it fixed his problem, but never heard back and sent it.

Mine was:

-libisl_la_CFLAGS = $(CFLAGS) -Wno-override-init
+libisl_la_CFLAGS = $(CFLAGS) -Wno-override-init $(VISIBILITY_CFLAGS)

since I didn't want to stick more CFLAGS in AM_CPPFLAGS.

I'm all for adding $(VISIBILITY_CFLAGS), wherever it goes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160728/276bd75d/attachment-0001.sig>