[Mesa-dev] [PATCH v2 35/35] isl/state: Add an assertion for IVB multisample array textures

[Pohjolainen, Topi]

On Tue, Jul 26, 2016 at 03:02:26PM -0700, Jason Ekstrand wrote:
> ---
>  src/intel/isl/isl_surface_state.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

Patches 33-35 are:

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>

> 
> diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c
> index fb23414..990b763 100644
> --- a/src/intel/isl/isl_surface_state.c
> +++ b/src/intel/isl/isl_surface_state.c
> @@ -239,6 +239,19 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state,
>     switch (s.SurfaceType) {
>     case SURFTYPE_1D:
>     case SURFTYPE_2D:
> +      /* From the Ivy Bridge PRM >> RENDER_SURFACE_STATE::MinimumArrayElement:
> +       *
> +       *    "If Number of Multisamples is not MULTISAMPLECOUNT_1, this field
> +       *    must be set to zero if this surface is used with sampling engine
> +       *    messages."
> +       *
> +       * This restriction appears to exist only on Ivy Bridge.
> +       */
> +      if (GEN_GEN == 7 && !GEN_IS_HASWELL && !ISL_DEV_IS_BAYTRAIL(dev) &&
> +          (info->view->usage & ISL_SURF_USAGE_TEXTURE_BIT) &&
> +          info->surf->samples > 1)
> +         assert(info->view->base_array_layer == 0);
> +
>        s.MinimumArrayElement = info->view->base_array_layer;
>  
>        /* From the Broadwell PRM >> RENDER_SURFACE_STATE::Depth:
> -- 
> 2.5.0.400.gff86faf
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev