[Mesa-dev] [PATCH] i965: Fix isoline reads in scalar TES.

Dave Airlie airlied at gmail.com
Wed Jun 1 05:54:17 UTC 2016


On 1 June 2016 at 15:45, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Isolines aren't reversed.  commit 5b2d8c2273c6f fixed this for the vec4
> TES backend, but not the scalar one.
>
> Found while debugging GL45-CTS.tessellation_shader.
> tessellation_control_to_tessellation_evaluation.gl_tessLevel.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> Cc: mesa-stable at lists.freedesktop.org

Seems sane,

Reviewed-by: Dave Airlie <airlied at redhat.com>

> ---
>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> index 58191fc..6b832e0 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> @@ -2746,7 +2746,7 @@ fs_visitor::nir_emit_tes_intrinsic(const fs_builder &bld,
>           break;
>        case BRW_TESS_DOMAIN_ISOLINE:
>           for (unsigned i = 0; i < 2; i++)
> -            bld.MOV(offset(dest, bld, i), component(fs_reg(ATTR, 0), 7 - i));
> +            bld.MOV(offset(dest, bld, i), component(fs_reg(ATTR, 0), 6 + i));
>           break;
>        }
>        break;
> --
> 2.8.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list