[Mesa-dev] [PATCH 2/5] mesa/formatquery: add a comment to clarify INTERNALFORMAT_PREFERRED

[Ian Romanick]

This patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 05/13/2016 07:57 AM, Alejandro Piñeiro wrote:
> The comment clarifies that the driver is called only to try to get
> a preferred internalformat, and that it was already checked if the
> format is supported or not.
> 
> Acked-by: Eduardo Lima <elima at igalia.com>
> Acked-by: Antia Puentes <apuentes at igalia.com>
> ---
>  src/mesa/main/formatquery.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c
> index 215c14f..1f21d17 100644
> --- a/src/mesa/main/formatquery.c
> +++ b/src/mesa/main/formatquery.c
> @@ -902,7 +902,10 @@ _mesa_GetInternalformativ(GLenum target, GLenum internalformat, GLenum pname,
>         *     format for representing resources of the specified <internalformat> is
>         *     returned in <params>.
>         *
> -       * Therefore, we let the driver answer.
> +       * Therefore, we let the driver answer. Note that if we reach this
> +       * point, it means that the internalformat is supported, so the driver
> +       * is called just to try to get a preferred format. If not supported,
> +       * GL_NONE was already returned and the driver is not called.
>         */
>        ctx->Driver.QueryInternalFormat(ctx, target, internalformat, pname,
>                                        buffer);
>