[Mesa-dev] [PATCH 2/9] nir/lower_indirect_derefs: Use the direct array deref for recursion

[Kenneth Graunke]

On Wednesday, June 1, 2016 2:44:53 PM PDT Jason Ekstrand wrote:
> This fixes about 100 of the new Vulkan CTS tests.
> 
> Signed-off-by: Jason Ekstrand <jason at jlekstrand.net>
> Cc: "12.0" <mesa-stable at lists.freedesktop.org>
> Cc: Connor Abbott <cwabbott0 at gmail.com>
> Cc: Ian Romanick <idr at freedesktop.org>
> Cc: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/compiler/nir/nir_lower_indirect_derefs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compiler/nir/nir_lower_indirect_derefs.c b/src/compiler/nir/nir_lower_indirect_derefs.c
> index 694a6e0..1bf4bf6 100644
> --- a/src/compiler/nir/nir_lower_indirect_derefs.c
> +++ b/src/compiler/nir/nir_lower_indirect_derefs.c
> @@ -50,7 +50,7 @@ emit_indirect_load_store(nir_builder *b, nir_intrinsic_instr *orig_instr,
>        direct.indirect = NIR_SRC_INIT;
>  
>        arr_parent->child = &direct.deref;
> -      emit_load_store(b, orig_instr, deref, &arr->deref, dest, src);
> +      emit_load_store(b, orig_instr, deref, &direct.deref, dest, src);
>        arr_parent->child = &arr->deref;
>     } else {
>        int mid = start + (end - start) / 2;
> 

This looks right to me - we want to be storing using the direct deref,
not the indirect one we're lowering.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160601/8a1b7482/attachment-0001.sig>