[Mesa-dev] [PATCH 0/2] fix load of unpacked double vector input varyings

Samuel Iglesias Gonsálvez siglesias at igalia.com
Thu Jun 2 05:57:26 UTC 2016



On 02/06/16 07:43, Timothy Arceri wrote:
> On Thu, 2016-06-02 at 07:22 +0200, Samuel Iglesias Gonsálvez wrote:
>> On 26/05/16 07:56, Samuel Iglesias Gonsálvez wrote:
>>>
>>> Hello,
>>>
>>> Timothy found that tests with unpacked double vector input varyings
>>> were failing in i965 driver. For example, this is happening when
>>> using explicit locations because Mesa disables varying packing for
>>> that case.
>>>
>>> These patches fix the following piglit test:
>>>
>>> spec/arb_gpu_shader_fp64/execution/vs-fs-explicit-locations
>>>
>>> Samuel Iglesias Gonsálvez (2):
>>>   i965/fs: fix offset when loading double vector input varyings
>>>   i965/fs: fix FS_OPCODE_CINTERP for unpacked double input varyings
>>>
>> These patches have a Tested-by (Thanks Timothy!) but they are still
>> unreviewed. Can someone take a look at them?
>>
>> Also, this patch [0] is still unreviewed.
> 
> If no one else takes a look at them over the next few days feel free to
> add my r-b to all three for what its worth they look ok to me.
> 
> Also don't forget to add tags for 12.0 stable before pushing.
> 

Sure :)

Thanks a lot!

Sam

> 
>>
>> Thanks,
>>
>> Sam
>>
>> [0] https://lists.freedesktop.org/archives/mesa-dev/2016-May/118759.h
>> tml
>>
>>
>>>
>>>  src/mesa/drivers/dri/i965/brw_fs.cpp     | 13 ++++++++++++-
>>>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22
>>> +++++++++++++++++++++-
>>>  2 files changed, 33 insertions(+), 2 deletions(-)
>>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160602/fe40f35f/attachment-0001.sig>


More information about the mesa-dev mailing list