[Mesa-dev] [PATCH 5/5] nir/spirv: Make a decoration switch complete

Jason Ekstrand jason at jlekstrand.net
Thu Jun 2 21:39:20 UTC 2016


Getting rid of the default case makes the compiler warn if we are missing
cases.  While we're here, we also add the one missing case.

Signed-off-by: Jason Ekstrand <jason at jlekstrand.net>
Cc: "12.0" <mesa-stable at lists.freedesktop.org>
---
 src/compiler/spirv/spirv_to_nir.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c
index f1fa6ee..f1bbfd5 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compiler/spirv/spirv_to_nir.c
@@ -533,6 +533,7 @@ struct_member_decoration_cb(struct vtn_builder *b,
    case SpvDecorationIndex:
    case SpvDecorationBinding:
    case SpvDecorationDescriptorSet:
+   case SpvDecorationLinkageAttributes:
    case SpvDecorationNoContraction:
    case SpvDecorationInputAttachmentIndex:
       vtn_warn("Decoration not allowed on struct members: %s",
@@ -553,9 +554,6 @@ struct_member_decoration_cb(struct vtn_builder *b,
       vtn_warn("Decoraiton only allowed for CL-style kernels: %s",
                spirv_decoration_to_string(dec->decoration));
       break;
-
-   default:
-      unreachable("Unhandled member decoration");
    }
 }
 
-- 
2.5.0.400.gff86faf



More information about the mesa-dev mailing list