[Mesa-dev] [PATCH] glsl: fix uninitialized instance variable

Rob Clark robdclark at gmail.com
Sat Jun 4 15:38:17 UTC 2016


On Sat, Jun 4, 2016 at 7:51 AM, Jan Ziak (⚛) atom-symbol.net
<0xe2.0x9a.0x9b at gmail.com> wrote:
> Valgrind detected that variable ir_copy_propagation_visitor::killed_all
> is uninitialized.
>
> Signed-off-by: Jan Ziak (⚛) atom-symbol.net <0xe2.0x9a.0x9b at gmail.com>

Reviewed-by: Rob Clark <robdclark at gmail.com>

> ---
>  src/compiler/glsl/opt_copy_propagation.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/compiler/glsl/opt_copy_propagation.cpp b/src/compiler/glsl/opt_copy_propagation.cpp
> index ae62921..18293ff 100644
> --- a/src/compiler/glsl/opt_copy_propagation.cpp
> +++ b/src/compiler/glsl/opt_copy_propagation.cpp
> @@ -76,6 +76,7 @@ public:
>        mem_ctx = ralloc_context(0);
>        this->acp = new(mem_ctx) exec_list;
>        this->kills = new(mem_ctx) exec_list;
> +      killed_all = false;
>     }
>     ~ir_copy_propagation_visitor()
>     {
> --
> 2.8.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list