[Mesa-dev] [PATCH 4/4] radeonsi: force non-displayable tiling based on surface dimensions

[Marek Olšák]

On Mon, Jun 6, 2016 at 10:58 AM, Michel Dänzer <michel at daenzer.net> wrote:
> On 03.06.2016 19:52, Marek Olšák wrote:
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> Simply ignore the "scanout" flag if the surface dimensions are unlikely
>> to be used by DCE.
>
> I don't like this.
>
> Ideally, there should be feedback from the display server so that he
> state tracker(s) can set the PIPE_BIND_SCANOUT flag only when it's
> really necessary.
>
> In the meantime, if we want to go for a hack like this, it should be in
> the place(s) setting the flag instead of the driver ignoring it.

Is st/dri the right place then? Or the DDX?

Can the DDX unset the scanout flag (e.g. reallocate) if a surface
isn't bound as a scanout?

The goal is to enable DCC for *everything* that isn't a DCE target.

>
>
>> Also ignore the "scanout" flag for non-2D, non-color, and AA surfaces.
>
> If there's any code setting PIPE_BIND_SCANOUT for such surfaces, it's
> buggy and should be fixed.

An assertion it is then.

Marek