[Mesa-dev] Mesa (master): Revert "egl: Check if API is supported when using eglBindAPI."

[Tapani Pälli]

On 06/06/2016 12:19 PM, Emil Velikov wrote:
> On 6 June 2016 at 10:10, Michel Dänzer <michel at daenzer.net> wrote:
>> On 04.06.2016 00:10, Marek Olšák wrote:
>>> On Fri, Jun 3, 2016 at 4:33 PM, Dieter Nützel <Dieter at nuetzel-hh.de> wrote:
>>>> Am 03.06.2016 11:47, schrieb Michel Dänzer:
>>>>>
>>>>> On 03.06.2016 18:34, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote:
>>>>>>
>>>>>> Module: Mesa
>>>>>> Branch: master
>>>>>> Commit: 8c361e84ad010552a42593fad4130befc58e9a6a
>>>>>> URL:
>>>>>> http://cgit.freedesktop.org/mesa/mesa/commit/?id=8c361e84ad010552a42593fad4130befc58e9a6a
>>>>>>
>>>>>> Author: Marek Olšák <marek.olsak at amd.com>
>>>>>> Date:   Fri Jun  3 11:25:19 2016 +0200
>>>>>>
>>>>>> Revert "egl: Check if API is supported when using eglBindAPI."
>>>>>>
>>>>>> This reverts commit e8b38ca202fbe8c281aeb81a4b64256983f185e0.
>>>>>>
>>>>>> It broke Glamor for Gallium at least.
>>>>>
>>>>>
>>>>> It exposed a bug in glamor, which is fixed by
>>>>>
>>>>> https://patchwork.freedesktop.org/patch/91214/
>>>>
>>>>
>>>> So what route should we take?
>>>>
>>>> Wait for the distros to catch up and enable it then, again?
>>>>
>>>> I was fallen in this, too.
>>>>
>>>> openSUSE 13.2 / Leap 42.1
>>>>
>>>> /usr/bin/Xorg: symbol lookup error:
>>>> /usr/lib64/xorg/modules/drivers/radeon_drv.so: undefined symbol:
>>>> exaGetPixmapDriverPrivate
>>>
>>> The commit caused Glamor to fail with:
>>> (WW) glamor0: Failed to get GLSL version
>>>
>>> We can't just kill Glamor support with a Mesa commit.
>>
>> Why do released versions of xserver/glamor have to work with unreleased
>> versions of Mesa?
>>
>>
>>> - keep the current eglBindAPI behavior forever
>>
>> So because we haven't been following the EGL spec, allowing broken EGL
>> apps to work by accident, we have to preserve that bug forever? I'm not
>> buying it.
>>
> Fully agree behind that one.
>
> On the overall topic here is a (related) idea I've had lying around:
>  - Contact distribution maintainers to patch their glamor packages as
> far back as possible.
> Having a mesa-maintainers ML or alike might help, they are likely to
> miss this in mesa-dev, plus pinging individuals does not scale.
>  - Decide on transition period, where we'll have a) the patch reverted
> or b) a glamor hack in place.
>  - Transition period is over - patch is back in/hack is out.
>
> The communication medium can be used to get the maintainers attention
> to other topics that directly concern them. They could also voice
> their like/dislike towards X and Y.
>
> How does the above sound ?

A transition period makes a lot of sense. Wanted to also add that 
there's one earlier similar case where Mesa exposes GL_OES_EGL_image (ES 
extension) on desktop GL just because of glamor/Xwayland:

b5df52b1128049bf688cace6e581a16d5f1ad5bb


> Emil
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>