[Mesa-dev] [PATCH 0/7] [RFC] Fix ralloc/rzalloc usage

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Tue Jun 7 14:26:35 UTC 2016


I had somehow missed the discussion there had happened about my
earlier ralloc findings. I rebased and fixed my earlier patch set
so here it is for others to see.

I'm not at all confident this is somehow good set, it may explode on
different setup than mine. I've been running this on my IVB where now all
piglit tests are returning same results as without this set.
Tapani Pälli did earlier point out there were some problems with different
setups so this anyway have to be tested well if it was ever to be applied
on mesa master branch.

/Juha-Pekka

Juha-Pekka Heikkila (7):
  util: Fix ralloc to use malloc instead of calloc
  glsl: Fix reading of uninitialized memory
  util: use rzalloc instead on ralloc in _mesa_hash_table_create()
  util: use rzalloc instead on ralloc in _mesa_set_create(()
  nir: zero allocated memory where needed
  i965/vec4: zero allocated memory where needed
  i965/fs: fill allocated memory with zeros where needed

 src/compiler/glsl/ast_to_hir.cpp                   |  2 +-
 src/compiler/glsl/glcpp/glcpp-parse.y              |  4 +--
 src/compiler/glsl/link_uniform_blocks.cpp          |  2 +-
 src/compiler/glsl_types.cpp                        |  2 +-
 src/compiler/nir/nir.c                             |  6 ++---
 src/compiler/nir/nir_opt_dce.c                     |  2 +-
 src/compiler/nir/nir_phi_builder.c                 |  2 +-
 src/compiler/nir/nir_search.c                      |  2 +-
 src/compiler/nir/nir_to_ssa.c                      |  2 +-
 src/compiler/nir/nir_worklist.c                    |  2 +-
 src/mesa/drivers/dri/i965/brw_fs.cpp               |  2 +-
 .../drivers/dri/i965/brw_fs_copy_propagation.cpp   |  2 +-
 .../dri/i965/brw_fs_dead_code_eliminate.cpp        |  4 +--
 .../dri/i965/brw_vec4_dead_code_eliminate.cpp      |  4 +--
 src/util/hash_table.c                              |  2 +-
 src/util/ralloc.c                                  | 31 ++++++++++++++++------
 src/util/ralloc.h                                  |  2 +-
 src/util/set.c                                     |  2 +-
 18 files changed, 45 insertions(+), 30 deletions(-)

-- 
1.9.1



More information about the mesa-dev mailing list