[Mesa-dev] [PATCH 00/31] Make more use of bitmasks v2

Mathias Fröhlich Mathias.Froehlich at gmx.net
Tue Jun 7 16:09:22 UTC 2016


Hi,

On Tuesday, June 07, 2016 16:15:58 Nicolai Hähnle wrote:
> Thanks for staying with this!
> 
> I know it's bike-shedding, and I'm not sure what other people's opinions 
> are on this matter, but having the duplication of u_bit_scan and 
> _mesa_bit_scan feels a bit annoying to me...

Well, yes, I can see that. But I feared that I open up a lot of additional
discussion if I basically start to unify galliums u_math.h with mesa.
So, I initially went with this least intrusive solution.

I have seen that src/util/bitset.h already just pulls ..gallium../util/u_math.h
directly. So given that the topic is about kind of bitsets I could imagine to pull
the u_bit_scan functions though util/bitset.h?
OTOH, that also felt somehow awkward to me ...
What do you recommend?

Mathias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160607/295e672c/attachment.html>


More information about the mesa-dev mailing list