[Mesa-dev] [PATCH 00/15] Misc cleanups (mesa/remap et al)

Ian Romanick idr at freedesktop.org
Tue Jun 7 18:26:23 UTC 2016


Patches 2, 3, 4 (with the trivial comment message nit addressed), 5, 6,
7, 8 (with the trivial comment message nit addressed), 10, 14, and 15 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

Patch 13 is

Acked-by: Ian Romanick <ian.d.romanick at intel.com>

I'd like to do some archaeology for patch 9 to be more sure about it.  I
think it's conceptually correct, but I'd like to be sure.

Patch 11 is obviously block on the status of patch 9.

On 06/07/2016 09:33 AM, Emil Velikov wrote:
> Hi all,
> 
> A selection of mostly dead code removal and "inline this one/two line function
> into the only caller" patches.
> 
> Note: PATCH 09/15 removes the initialisation of _mesa_init_remap_table() from
> once per API to once per context. Based on my humble understanding current
> approach was a side effect of a) early process which used separate remap tables
> and b) having the FEATURE_{API} flags.
> That said, I could have misunderstood things, so _please_ give it a look/test.
> 
> Thanks
> Emil
> 
> Emil Velikov (15):
>   dri/common: remove unused libdri_test_stubs.la
>   mesa: remove unused function _mesa_map_static_functions()
>   glapi: remap_helper.py: remove MESA_alt_functions
>   mesa: remove unused _mesa_map_function_array()
>   mesa: remove used _mesa_get_function_spec() and gl_function_remap
>   mesa: make _mesa_map_function_spec() static
>   mesa: use native types when possible
>   mesa: kill off _mesa_do_init_remap_table()
>   mesa: execute _mesa_init_remap_table() only once
>   mesa: remove _mesa_init_get_hash()
>   mesa: cleanup the remaining API references in one_time_init()
>   gallium: remove st_api::get_proc_address hook
>   st/mesa: use c99 initializer for st_gl_api
>   st/mesa: remove unneeded break from st_api_create_context()
>   st/mesa: inline _mesa_create_context() into its only caller
> 
>  src/gallium/include/state_tracker/st_api.h   |  12 ---
>  src/mapi/glapi/gen/remap_helper.py           |  42 ---------
>  src/mesa/drivers/dri/common/Makefile.am      |   6 +-
>  src/mesa/drivers/dri/common/Makefile.sources |   3 -
>  src/mesa/drivers/dri/common/dri_test.c       |  96 ---------------------
>  src/mesa/main/context.c                      |  90 +++++---------------
>  src/mesa/main/context.h                      |   9 --
>  src/mesa/main/get.c                          |  65 --------------
>  src/mesa/main/remap.c                        | 122 ++++-----------------------
>  src/mesa/main/remap.h                        |  18 ----
>  src/mesa/state_tracker/st_context.c          |   8 +-
>  src/mesa/state_tracker/st_manager.c          |  34 +++-----
>  12 files changed, 57 insertions(+), 448 deletions(-)
>  delete mode 100644 src/mesa/drivers/dri/common/dri_test.c
> 



More information about the mesa-dev mailing list