[Mesa-dev] [PATCH] mesa: expose ARB_compute_shader with compat profile

[Nanley Chery]

On Wed, May 25, 2016 at 12:52:38PM -0700, Matt Turner wrote:
> On Wed, May 25, 2016 at 12:17 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
> > This fixes use of compute shaders with some NVIDIA GL 4.3 samples which
> > require a compat profile.
> 
> I'm confused.
> 
> The samples you're talking about... use 4.3 compatibility? We already
> don't support compatibility profile, so you presumably have to hack
> that on.
> 
> The ARB_compute_shader extension spec says it requires 4.2, and we
> don't expose 4.2 with the compatibility profile. I think you should
> have some justification for why it's safe to expose in compatibility
> profile, since that's a pretty big change. Or, you don't want to
> expose it in compatibility but you need this patch to enable it with
> the 4.2-compat hack enabled...?
> 
> Strangely, ARB_compute_shader says "GLL, GLC" in extensions_table.h,
> but it's only core-enabled on my glxinfo.

Because extensions_table.h has "GLL" in the ARB_compute_shader entry,
the extension is already exposed in all compatibility contexts. This
patch fixes the bug of advertising the extension externally, but
internally failing to do the logic required by the extension.

- Nanley

> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev