[Mesa-dev] Mesa (master): mesa: Let compute shaders work in compatibility profiles

[Nanley Chery]

On Thu, Jun 09, 2016 at 04:41:36PM -0600, Brian Paul wrote:
> Some sort of linker error.  The appveyor pages shows the details.  I still
> haven't figured it out.
> 

I wrote a patch sometime ago that changes the macro to avoid referencing the table.
I can send it out to the list if you'd like.

- Nanley

> -Brian
> 
> On 06/09/2016 04:28 PM, Samuel Pitoiset wrote:
> > 
> > 
> > On 06/10/2016 12:21 AM, Brian Paul wrote:
> > > This change seems to have broke the Windows build.  I'm digging into
> > > it...
> > 
> > mmh, I saw the AppVeyor notification but usually it seems to be
> > unreliable. Let me know what's going on, thanks.
> > 
> > > 
> > > -Brian
> > > 
> > > 
> > > On 06/09/2016 01:10 PM, Samuel Pitoiset wrote:
> > > > Module: Mesa
> > > > Branch: master
> > > > Commit: 5e2d25894b962aae9158261897e13843377e3b95
> > > > URL:
> > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_mesa_commit_-3Fid-3D5e2d25894b962aae9158261897e13843377e3b95&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8&m=eYmG4khuEM_z87lRSCz031iFtL8eLNwNFa3rRT7zz5U&s=sDI8gjpNg7j5P_t3PgOymwD9xO00gNEzOCq0Ky6m7SU&e=
> > > > 
> > > > 
> > > > 
> > > > Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> > > > Date:   Wed May 25 21:17:24 2016 +0200
> > > > 
> > > > mesa: Let compute shaders work in compatibility profiles
> > > > 
> > > > The extension is already advertised in compatibility profile, but
> > > > the _mesa_has_compute_shaders only returns true in core profile.
> > > > If we advertise it, we should allow it to work.
> > > > 
> > > > Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> > > > Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
> > > > Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>
> > > > 
> > > > ---
> > > > 
> > > >   src/mesa/main/context.h | 2 +-
> > > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
> > > > index ef19cc6..593ced5 100644
> > > > --- a/src/mesa/main/context.h
> > > > +++ b/src/mesa/main/context.h
> > > > @@ -343,7 +343,7 @@ _mesa_has_geometry_shaders(const struct gl_context
> > > > *ctx)
> > > >   static inline bool
> > > >   _mesa_has_compute_shaders(const struct gl_context *ctx)
> > > >   {
> > > > -   return (ctx->API == API_OPENGL_CORE &&
> > > > ctx->Extensions.ARB_compute_shader) ||
> > > > +   return _mesa_has_ARB_compute_shader(ctx) ||
> > > >         (ctx->API == API_OPENGLES2 && ctx->Version >= 31);
> > > >   }
> > > > 
> > > > 
> > > > _______________________________________________
> > > > mesa-commit mailing list
> > > > mesa-commit at lists.freedesktop.org
> > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Dcommit&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8&m=eYmG4khuEM_z87lRSCz031iFtL8eLNwNFa3rRT7zz5U&s=fF_hIV63v6jSAMz9e6SllSHUbHL2j36mgB7mVuxs8CE&e=
> > > > 
> > > > 
> > > > 
> > > > 
> > > 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev