[Mesa-dev] [Bug 96358] SSO: wrong interface validation between GS and VS (regresion due to latest gles 3.1)

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jun 10 15:05:15 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=96358

--- Comment #4 from Ian Romanick <idr at freedesktop.org> ---
Created attachment 124453
  --> https://bugs.freedesktop.org/attachment.cgi?id=124453&action=edit
Strip arrayness from interface block names in some IO validation

This patch is a bit of a hack, but I think it should fix the problem.  If it
works, I'll improve it & send to the list for review.

If this doesn't fix the problem, I think we should just remove IO validation
from desktop GL altogether.

diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c
index 5a46cfe..10a9544 100644
--- a/src/mesa/main/pipelineobj.c
+++ b/src/mesa/main/pipelineobj.c
@@ -928,8 +928,7 @@ _mesa_validate_program_pipeline(struct gl_context* ctx,
     * Based on this, only perform the most-strict checking on ES or when the
     * application has created a debug context.
     */
-   if ((_mesa_is_gles(ctx) || (ctx->Const.ContextFlags &
GL_CONTEXT_FLAG_DEBUG_BIT)) &&
-       !_mesa_validate_pipeline_io(pipe))
+   if (_mesa_is_gles(ctx) && !_mesa_validate_pipeline_io(pipe))
       return GL_FALSE;

    pipe->Validated = GL_TRUE;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160610/57cc4200/attachment.html>


More information about the mesa-dev mailing list