[Mesa-dev] [PATCH 24/64] isl/state: Emit no-op mip tail setup on SKL

Jason Ekstrand jason at jlekstrand.net
Sat Jun 11 16:02:39 UTC 2016


This hasn't ever been a problem in the past but it is recommended by the
hardware docs.
---
 src/intel/isl/isl_surface_state.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c
index 0d26619..fe0402f 100644
--- a/src/intel/isl/isl_surface_state.c
+++ b/src/intel/isl/isl_surface_state.c
@@ -277,6 +277,14 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state,
       s.MIPCountLOD = MAX(info->view->levels, 1) - 1;
    }
 
+#if GEN_GEN >= 9
+   /* We don't use miptails yet.  The PRM recommends that you set "Mip Tail
+    * Start LOD" to 15 to prevent the hardware from trying to use them.
+    */
+   s.TiledResourceMode = NONE;
+   s.MipTailStartLOD = 15;
+#endif
+
    const struct isl_extent3d image_align = get_image_alignment(info->surf);
    s.SurfaceVerticalAlignment = isl_to_gen_valign[image_align.height];
    s.SurfaceHorizontalAlignment = isl_to_gen_halign[image_align.width];
-- 
2.5.0.400.gff86faf



More information about the mesa-dev mailing list