[Mesa-dev] [PATCH 00/64] i965: Start using ISL for filling out surface states

[Emil Velikov]

On 11 June 2016 at 17:02, Jason Ekstrand <jason at jlekstrand.net> wrote:

> The next 20 patches or so are general ISL cleanups and fixes.  If no one is
> too opposed, I'd like to back-port the whole pile to 12.0.  There are two
> reasons for this: First, ISL is new and this is a substantial cleanup;
> back-porting it will make back-porting will keep the initial release of ISL
> cleaner and make back-porting other patches easier in the future.  Second,
> in the middle of the series are a couple of changes that fix some 850
> Vulkan CTS tests on Haswell.
>
No serious objections on getting these in 12.0. A bunch of small
suggestions though.

>   i965/gen4: Subtract 1 from buffer sizes
Please polish the commit message a bit.

>   isl/state: Put surface format setup at the top
>   isl/state: Put all dimension setup together and towards the top
>   isl/state: Put pitch calculations together
Are these solely for cosmetic/ease of read reasons or there's
something more to it ? Can you please mention in the commit message ?

>   genxml: Add enough XML for gens 4, 4.5, and 5 to get SURFACE_STATE
Let me see if I can quickly cook something for the Android build.


>   isl: Add support for filling out surface states all the way back to
>     gen4
Ditto.


>   isl/formats: Mark RAW as having a block size of 1 byte
Worth mentioning why we want that ?

Thanks
Emil