[Mesa-dev] [PATCH 05/10] gallium: change end_query() to return boolean

Marek Olšák maraeo at gmail.com
Tue Jun 14 17:45:56 UTC 2016


On Tue, Jun 14, 2016 at 6:24 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Tue, Jun 14, 2016 at 12:19 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>> On 14.06.2016 17:57, Rob Clark wrote:
>>>
>>> From: Rob Clark <robclark at freedesktop.org>
>>>
>>> s/bool/boolean/ to make it match the other APIs.
>>
>>
>> Please no. C has finally grown a proper bool type, we should use it where
>> possible. If anything, make the patch go in the other direction.
>
> FWIW I've eradicated boolean from nouveau except for the gallium API
> interfaces. Would definitely be in favor of flipping those to bool.

I'm in favor of bool too and would like to see boolean/TRUE/FALSE
disappear from radeon-specific code at least.

Marek


More information about the mesa-dev mailing list