[Mesa-dev] [PATCH] radeon: remove unnecessary checks
Jakob Sinclair
sinclair.jakob at openmailbox.org
Tue Jun 14 18:19:21 UTC 2016
On 2016-06-13 12:02, Nicolai Hähnle wrote:
>
> Meh. This is the kind of thing where Coverity should perhaps just shut
> up :/
I do agree with you that Coverity should perhaps shut up about this
kinda thing
but I couldn't see a reason to have these checks in the code. They
really didn't
contribute to my understanding of the code. Although I may be missing
something
important here.
> Anyway...
> I think for consistency, you should also remove the '- PIPE_SWIZZLE_X'
> here, similar to the first hunk. With that changed,
Forgot about that one. I agree with this change.
> Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
Thanks!
--
Mvh Jakob Sinclair
More information about the mesa-dev
mailing list