[Mesa-dev] [PATCH 2/2] mesa: replace 1.F with 0.F

[Nayan Deshmukh]

Hi Brian,

Sorry for the typo in the commit message.

The patch was aimed to have a uniform coding style, just a suggestion given
by emil.

Regards,
Nayan.

On Wed, Jun 15, 2016 at 8:26 PM, Brian Paul <brianp at vmware.com> wrote:

> On 06/15/2016 07:02 AM, Eric Engestrom wrote:
>
>> On Wed, Jun 15, 2016 at 03:38:05PM +0530, Nayan Deshmukh wrote:
>>
>>> Signed-off-by: Nayan Deshmukh <nayan26deshmukh at gmail.com>
>>> ---
>>>   src/mesa/drivers/dri/r200/r200_swtcl.c | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/src/mesa/drivers/dri/r200/r200_swtcl.c
>>> b/src/mesa/drivers/dri/r200/r200_swtcl.c
>>> index 72f09ae..d3fb37f 100644
>>> --- a/src/mesa/drivers/dri/r200/r200_swtcl.c
>>> +++ b/src/mesa/drivers/dri/r200/r200_swtcl.c
>>> @@ -835,9 +835,9 @@ r200PointsBitmap( struct gl_context *ctx, GLint px,
>>> GLint py,
>>>         else
>>>            f = _swrast_z_to_fogfactor(ctx, ctx->Current.RasterDistance);
>>>
>>> -      color[0] = f * rc[0] + (1.F - f) * fc[0];
>>> -      color[1] = f * rc[1] + (1.F - f) * fc[1];
>>> -      color[2] = f * rc[2] + (1.F - f) * fc[2];
>>> +      color[0] = f * rc[0] + (1.0F - f) * fc[0];
>>> +      color[1] = f * rc[1] + (1.0F - f) * fc[1];
>>> +      color[2] = f * rc[2] + (1.0F - f) * fc[2];
>>>         color[3] = rc[3];
>>>
>>>         UNCLAMPED_FLOAT_TO_CHAN(vert.tv.color.red,   color[0]);
>>> --
>>> 2.5.5
>>>
>>
>> Commit title has a typo: s/0.F/1.0F/
>>
>
> Looks like you're replacing 1.F with 1.0F, certainly not replacing zero
> with one or vice versa.  :)
>
> BTW, why is this change needed?
>
> -Brian
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160615/2f3e1fbb/attachment.html>