[Mesa-dev] [PATCH] anv: Fix a harmless overflow warning

Chad Versace chad.versace at intel.com
Wed Jun 15 17:34:03 UTC 2016


On Tue 14 Jun 2016, Jason Ekstrand wrote:
> On Jun 14, 2016 4:23 PM, "Chad Versace" <chad.versace at intel.com> wrote:
> >
> > anv_pipeline_binding::index is a uint8_t, but some code assigned to it
> > UINT16_MAX.
> > ---
> >  src/intel/vulkan/anv_pipeline.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/intel/vulkan/anv_pipeline.c
> b/src/intel/vulkan/anv_pipeline.c
> > index 60b7c6b..b41e11e 100644
> > --- a/src/intel/vulkan/anv_pipeline.c
> > +++ b/src/intel/vulkan/anv_pipeline.c
> > @@ -664,7 +664,7 @@ anv_pipeline_compile_fs(struct anv_pipeline *pipeline,
> >           rt_bindings[0] = (struct anv_pipeline_binding) {
> >              .set = ANV_DESCRIPTOR_SET_COLOR_ATTACHMENTS,
> >              .binding = 0,
> > -            .index = UINT16_MAX,
> > +            .index = UINT8_MAX,
> 
> I believe we have a descriptive #define specifically for render targets.
> Probably better to use that.

What #define did you have in mind? The only relevant one I found was

  #define MAX_RTS 8


More information about the mesa-dev mailing list