[Mesa-dev] [PATCH 1/2] gallium: replace [0-9]*.f with [0-9]*.0f

Jose Fonseca jfonseca at vmware.com
Wed Jun 15 20:57:44 UTC 2016


On 15/06/16 18:13, Emil Velikov wrote:
> On 15 June 2016 at 15:58, Brian Paul <brianp at vmware.com> wrote:
>> Why is this change needed?  Does some compiler balk at 1.f?
>>
> Since I'm the one 'to blame' for these patches I'll answer - consistency.
> These are the only remaining cases where the trailing zero was missing :-)
>
> -Emil

Although I'm not one of them myself, some people prefer the short ".f" 
instead of ".0f".  So, unless we all plant to make a point out of 
avoiding ".f" when writing new code, and call it out on patch reviews, 
this consistency will be short lived.

That is, I think that attempts to standardize minor cosmetic issues is a 
distraction.

I mean, we can't even standardize on major cosmetic things like 
indentation across whole Mesa, and we have such a high level of review 
request traffic already.

My 2c.

Jose



More information about the mesa-dev mailing list