[Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

[Jose Fonseca]

On 15/06/16 18:58, Brian Paul wrote:
> To match what's done in the automake build.
> ---
>   src/SConscript      | 43 +++++++++++++++++++++++++++++++++++++++++++
>   src/mesa/SConscript | 43 ++-----------------------------------------
>   2 files changed, 45 insertions(+), 41 deletions(-)
>
> diff --git a/src/SConscript b/src/SConscript
> index 4ba0a32..719aa69 100644
> --- a/src/SConscript
> +++ b/src/SConscript
> @@ -1,5 +1,6 @@
>   Import('*')
>
> +import os

Nitpick: personally I prefer the Python import at the top.


Either way,

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>