[Mesa-dev] Trouble with missing git_sha1.h when building from a fresh tree

[Haixia Shi]

Bisect shows the problem started at commit
3689ef32afdafbb030069e560aac0e563fc29048
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Mon May 30 12:32:05 2016 +0100

    automake: rework the git_sha1.h rule, include in tarball

    As we'll need the file in the release tarball, rework the rule so that
    the file is regenerated _only_ if we're in a git repository.

    With this in place we can build vulkan (anv) from a release tarball.

    Cc: Jason Ekstrand <jason.ekstrand at intel.com>
    Cc: Kristian Høgsberg Kristensen <krh at bitplanet.net>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

I'm not building from a release tarball, but the workflow first copies the
source tree to a tmp directory (without the .git directory), so there's no
git_sha1.h file, and the file is not generated either.

On Thu, Jun 16, 2016 at 11:46 AM, Haixia Shi <hshi at chromium.org> wrote:

> Posting a question in case someone already know the issue.
>
> I'm observing "missing git_sha1.h" errors sometime after Emil's git_sha1.h
> patches by May 31st. This is not fixed at TOT with the latest patches on
> Makefile.am.
>
> The problem only happens if src/git_sha1.h doesn't exist already. I just
> need to put a dummy git_sha1.h file there to work around the error.
>
> There's a similar bug filed (
> https://bugs.freedesktop.org/show_bug.cgi?id=50976) but the fix for that
> one patches src/Makefile directly, whereas my build flow only requires
> Makefile.am.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160616/fc988fb8/attachment.html>