[Mesa-dev] [RFC 2/7] pipe-loader-drm: Add common pipe_screen refcounting

Rob Clark robdclark at gmail.com
Fri Jun 17 18:28:59 UTC 2016


On Fri, Jun 17, 2016 at 2:23 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Hi Rob,
>
> On 17 June 2016 at 18:45, Rob Herring <robh at kernel.org> wrote:
>
>>  struct pipe_screen {
>> +   int refcnt;
> Can you please use struct pipe_reference throughout and the respective
> pipe_reference API from src/gallium/auxiliary/util/u_inlines.h.

jfyi, the original per-driver implementation didn't use pipe_reference
since (iirc) there were some assumptions somewhere or other that
pipe_reference was the first struct member.  But yeah, now that we can
move it to the top of pipe_screen, we should do it properly


BR,
-R

> Thank you very much for doing this !
> Emil


More information about the mesa-dev mailing list