[Mesa-dev] [PATCH] st/mesa: Remove tautological check (v2)

Francesco Ansanelli francians at gmail.com
Fri Jun 17 17:15:25 UTC 2016


Hi Erik,
Thanks for your feedback.
Can you suggest a better subject?
After some thinking, should I cast gl_buffer_index before calling the
function?
Thanks
Francesco
Il 17 giu 2016 12:39, "Erik Faye-Lund" <kusmabite at gmail.com> ha scritto:

> Now the subject no longer makes any sense.
>
> On Thu, Jun 16, 2016 at 7:02 AM,  <francians at gmail.com> wrote:
> > From: Francesco Ansanelli <francians at gmail.com>
> >
> > ---
> >  src/mesa/state_tracker/st_cb_fbo.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/mesa/state_tracker/st_cb_fbo.c
> b/src/mesa/state_tracker/st_cb_fbo.c
> > index a53b95a..950ec3e 100644
> > --- a/src/mesa/state_tracker/st_cb_fbo.c
> > +++ b/src/mesa/state_tracker/st_cb_fbo.c
> > @@ -704,7 +704,7 @@ st_DrawBuffers(struct gl_context *ctx, GLsizei
> count, const GLenum *buffers)
> >
> >     /* add the renderbuffers on demand */
> >     for (i = 0; i < fb->_NumColorDrawBuffers; i++) {
> > -      gl_buffer_index idx = fb->_ColorDrawBufferIndexes[i];
> > +      GLint idx = fb->_ColorDrawBufferIndexes[i];
> >
> >        if (idx >= 0) {
> >           st_manager_add_color_renderbuffer(st, fb, idx);
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160617/1b1e25d8/attachment.html>


More information about the mesa-dev mailing list