[Mesa-dev] [PATCH 33/64] genxml: Make X/Y Offset field of SURFACE_STATE a uint

[Chad Versace]

On Sat 11 Jun 2016, Jason Ekstrand wrote:
> THe offset type has special implications that it's intended to be some form
> of aligned memory address.  These assumptions allow it to handle the case
> where there is some alignment requirement on the offset and the bottom bits
> are used for other things.  However, the offsets in the surface state field
> are really just unsigned integers.
> ---
>  src/intel/genxml/gen45.xml | 4 ++--
>  src/intel/genxml/gen5.xml  | 4 ++--
>  src/intel/genxml/gen6.xml  | 4 ++--
>  src/intel/genxml/gen7.xml  | 4 ++--
>  src/intel/genxml/gen75.xml | 4 ++--
>  src/intel/genxml/gen8.xml  | 4 ++--
>  src/intel/genxml/gen9.xml  | 4 ++--
>  7 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/src/intel/genxml/gen45.xml b/src/intel/genxml/gen45.xml
> index 973b3bb..ae483b7 100644
> --- a/src/intel/genxml/gen45.xml
> +++ b/src/intel/genxml/gen45.xml
> @@ -50,7 +50,7 @@
>      <field name="Surface Min LOD" start="156" end="159" type="uint"/>
>      <field name="Minimum Array Element" start="145" end="155" type="uint"/>
>      <field name="Render Target View Extent" start="136" end="144" type="uint"/>
> -    <field name="X Offset" start="185" end="191" type="offset"/>
> -    <field name="Y Offset" start="180" end="183" type="offset"/>
> +    <field name="X Offset" start="185" end="191" type="uint"/>
> +    <field name="Y Offset" start="180" end="183" type="uint"/>
>    </struct>
>  </genxml>

[snip]

>From inspecting the original secret XML, this change looks like it better
matches the original XML's intent.

Reviewed-by: Chad Versace <chad.versace at intel.com>

Interestingly, the type of this field in the original XML is
"PixelOffset". All structure fields that have type PixelOffset
match '*_SURFACE_STATE.*(X|Y)Offset*'.