[Mesa-dev] [PATCH 3/4] automake: don't mandate git_sha1.h/MESA_GIT_SHA1

Eric Engestrom eric.engestrom at imgtec.com
Wed Jun 22 15:59:30 UTC 2016


On Wed, Jun 22, 2016 at 01:04:42PM +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> It has proven subtle to get it right both form the build side POV (see

s/form/from/

Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

> commit list below) and builders due to their varying workflows.
> 
> Furthermore it does not fully fulfil the reason why it was enforced -
> to detect uniqueness between different builds, in order to distinguish
> and invalidate Vulkan/GL caches.
> 
> With that having a much better solution (previous commit) we can drop
> this solution.
> 
> This effectively reverts the following commits:
> 359d9dfec33 ("mesa: automake: add directory prefix for git_sha1.h")
> 2c424e00c39 ("mesa: automake: ensure that git_sha1.h.tmp has the right
> attributes")
> b7f7ec78435 ("mesa: automake: distclean git_sha1.h when building OOT")
> 8229fe68b5d ("automake: get in-tree `make distclean' working again.")
> 
> Cc: Timo Aaltonen <tjaalton at debian.org>
> Cc: Haixia Shi <hshi at chromium.org>
> Cc: Jason Ekstrand <jason at jlekstrand.net>
> Cc: mesa-stable at lists.freedesktop.org
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---


More information about the mesa-dev mailing list