[Mesa-dev] [PATCH 2/3] vl: add parameters for VAAPI encode

[Zhang, Boyuan]

Agree, please see the new patch set I just sent.

-----Original Message-----
From: Christian König [mailto:deathsimple at vodafone.de] 
Sent: June-22-16 3:29 AM
To: Zhang, Boyuan; mesa-dev at lists.freedesktop.org
Subject: Re: [PATCH 2/3] vl: add parameters for VAAPI encode

Am 21.06.2016 um 16:50 schrieb Boyuan Zhang:
> Signed-off-by: Boyuan Zhang <boyuan.zhang at amd.com>

Please move that patch to the end of the series. E.g. implement the existing interface first, then add the new one and make the changes to support the new one.

Regards,
Christian.

> ---
>   src/gallium/include/pipe/p_video_state.h | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/src/gallium/include/pipe/p_video_state.h 
> b/src/gallium/include/pipe/p_video_state.h
> index d353be6..d519d17 100644
> --- a/src/gallium/include/pipe/p_video_state.h
> +++ b/src/gallium/include/pipe/p_video_state.h
> @@ -131,6 +131,7 @@ enum pipe_h264_enc_rate_control_method
>   struct pipe_picture_desc
>   {
>      enum pipe_video_profile profile;
> +   enum pipe_video_entrypoint entry_point;
>   };
>   
>   struct pipe_quant_matrix
> @@ -369,11 +370,23 @@ struct pipe_h264_enc_picture_desc
>   
>      enum pipe_h264_enc_picture_type picture_type;
>      unsigned frame_num;
> +   unsigned frame_num_cnt;
> +   unsigned p_remain;
> +   unsigned i_remain;
> +   unsigned idr_pic_id;
> +   unsigned gop_cnt;
>      unsigned pic_order_cnt;
>      unsigned ref_idx_l0;
>      unsigned ref_idx_l1;
> +   unsigned gop_size;
>   
>      bool not_referenced;
> +   bool is_idr;
> +   bool has_ref_pic_list;
> +   bool enable_low_level_control;
> +   unsigned int ref_pic_list_0[32];
> +   unsigned int ref_pic_list_1[32];
> +   unsigned int frame_idx[32];
>   };
>   
>   struct pipe_h265_sps