[Mesa-dev] [PATCH] anv: Add anv_render_pass_attachment::store_op

Jason Ekstrand jason at jlekstrand.net
Thu Jun 23 21:12:19 UTC 2016


R-B

On Thu, Jun 23, 2016 at 1:56 PM, Chad Versace <chad.versace at intel.com>
wrote:

> Will be needed for resolving auxiliary surfaces.
>
> I didn't add anv_render_pass_attachment::stencil_store_op, as the driver
> would likely never use it, as stencil surfaces never have auxiliary
> surfaces.
> ---
>  src/intel/vulkan/anv_pass.c    | 3 +--
>  src/intel/vulkan/anv_private.h | 1 +
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c
> index b740754..69c3c7e 100644
> --- a/src/intel/vulkan/anv_pass.c
> +++ b/src/intel/vulkan/anv_pass.c
> @@ -60,9 +60,8 @@ VkResult anv_CreateRenderPass(
>        att->format = pCreateInfo->pAttachments[i].format;
>        att->samples = pCreateInfo->pAttachments[i].samples;
>        att->load_op = pCreateInfo->pAttachments[i].loadOp;
> +      att->store_op = pCreateInfo->pAttachments[i].storeOp;
>        att->stencil_load_op = pCreateInfo->pAttachments[i].stencilLoadOp;
> -      // att->store_op = pCreateInfo->pAttachments[i].storeOp;
> -      // att->stencil_store_op =
> pCreateInfo->pAttachments[i].stencilStoreOp;
>     }
>
>     uint32_t subpass_attachment_count = 0, *p;
> diff --git a/src/intel/vulkan/anv_private.h
> b/src/intel/vulkan/anv_private.h
> index 50b860c..8c2ffd8 100644
> --- a/src/intel/vulkan/anv_private.h
> +++ b/src/intel/vulkan/anv_private.h
> @@ -1812,6 +1812,7 @@ struct anv_render_pass_attachment {
>     VkFormat                                     format;
>     uint32_t                                     samples;
>     VkAttachmentLoadOp                           load_op;
> +   VkAttachmentStoreOp                          store_op;
>     VkAttachmentLoadOp                           stencil_load_op;
>  };
>
> --
> 2.9.0.rc2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160623/3c14afc3/attachment.html>


More information about the mesa-dev mailing list