[Mesa-dev] [PATCH 3/3] i965: Delete send-from-GRF only opcodes from implied_mrf_writes().

[Matt Turner]

On Thu, Jun 23, 2016 at 2:06 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> These only exist post-Sandybridge, and always use send-from-GRF.
> So inst->base_mrf will be -1, and we will have already returned 0.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_fs.cpp | 18 ------------------
>  1 file changed, 18 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
> index 7a9e785..5fba621d 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> @@ -979,21 +979,17 @@ fs_visitor::implied_mrf_writes(fs_inst *inst)
>     case FS_OPCODE_TXB:
>     case SHADER_OPCODE_TXD:
>     case SHADER_OPCODE_TXF:
> -   case SHADER_OPCODE_TXF_LZ:
>     case SHADER_OPCODE_TXF_CMS:
> -   case SHADER_OPCODE_TXF_CMS_W:
>     case SHADER_OPCODE_TXF_MCS:
>     case SHADER_OPCODE_TG4:
>     case SHADER_OPCODE_TG4_OFFSET:
>     case SHADER_OPCODE_TXL:
> -   case SHADER_OPCODE_TXL_LZ:
>     case SHADER_OPCODE_TXS:
>     case SHADER_OPCODE_LOD:
>     case SHADER_OPCODE_SAMPLEINFO:
>        return 1;
>     case FS_OPCODE_FB_WRITE:
>        return 2;
> -   case FS_OPCODE_GET_BUFFER_SIZE:
>     case FS_OPCODE_UNIFORM_PULL_CONSTANT_LOAD:
>     case SHADER_OPCODE_GEN4_SCRATCH_READ:
>        return 1;
> @@ -1001,20 +997,6 @@ fs_visitor::implied_mrf_writes(fs_inst *inst)
>        return inst->mlen;
>     case SHADER_OPCODE_GEN4_SCRATCH_WRITE:
>        return inst->mlen;
> -   case SHADER_OPCODE_UNTYPED_ATOMIC:
> -   case SHADER_OPCODE_UNTYPED_SURFACE_READ:
> -   case SHADER_OPCODE_UNTYPED_SURFACE_WRITE:
> -   case SHADER_OPCODE_TYPED_ATOMIC:
> -   case SHADER_OPCODE_TYPED_SURFACE_READ:
> -   case SHADER_OPCODE_TYPED_SURFACE_WRITE:
> -   case SHADER_OPCODE_URB_WRITE_SIMD8:
> -   case SHADER_OPCODE_URB_WRITE_SIMD8_PER_SLOT:
> -   case SHADER_OPCODE_URB_WRITE_SIMD8_MASKED:
> -   case SHADER_OPCODE_URB_WRITE_SIMD8_MASKED_PER_SLOT:
> -   case FS_OPCODE_INTERPOLATE_AT_CENTROID:
> -   case FS_OPCODE_INTERPOLATE_AT_SAMPLE:
> -   case FS_OPCODE_INTERPOLATE_AT_SHARED_OFFSET:
> -   case FS_OPCODE_INTERPOLATE_AT_PER_SLOT_OFFSET:
>        return 0;

Looks like you wanted to remove the return 0 as well.

The series is

Reviewed-by: Matt Turner <mattst88 at gmail.com>