[Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

[Samuel Pitoiset]

On 06/28/2016 12:02 AM, Ilia Mirkin wrote:
> This loses you saturation. Does the target account for this?

No saturate flag for FADD32I.

>
> On Mon, Jun 27, 2016 at 5:55 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> FADD only allows to emit 19-bits immediates.
>>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> Cc: <mesa-stable at lists.freedesktop.org>
>> ---
>>  src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp
>> index c7bd4e1..ccc169e 100644
>> --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp
>> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp
>> @@ -1215,7 +1215,7 @@ CodeEmitterGM107::emitDSETP()
>>  void
>>  CodeEmitterGM107::emitFADD()
>>  {
>> -   if (!longIMMD(insn->src(1))) {
>> +   if (insn->src(1).getFile() != FILE_IMMEDIATE) {
>>        switch (insn->src(1).getFile()) {
>>        case FILE_GPR:
>>           emitInsn(0x5c580000);
>> --
>> 2.8.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev