[Mesa-dev] [PATCH 4/4] Revert "isl: Don't filter tiling flags if a specific tiling bit is set"
Nanley Chery
nanleychery at gmail.com
Mon Jun 27 23:35:28 UTC 2016
This reverts commit 091f1da902c71ac8d3d27b325a118e2f683f1ae5.
Although a user may specify a specfic tiling bit, ISL should still
prevent incompatible tiling/surface combinations.
Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
---
Prior to patch https://patchwork.freedesktop.org/patch/95338/ ,
this change made crucible tests which attempted to make a linear
depth image assert-fail.
src/intel/isl/isl.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index 77b570d..f09863e4 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/isl/isl.c
@@ -187,14 +187,11 @@ isl_surf_choose_tiling(const struct isl_device *dev,
{
isl_tiling_flags_t tiling_flags = info->tiling_flags;
- /* Filter if multiple tiling options are given */
- if (!isl_is_pow2(tiling_flags)) {
- if (ISL_DEV_GEN(dev) >= 7) {
- gen7_filter_tiling(dev, info, &tiling_flags);
- } else {
- isl_finishme("%s: gen%u", __func__, ISL_DEV_GEN(dev));
- gen7_filter_tiling(dev, info, &tiling_flags);
- }
+ if (ISL_DEV_GEN(dev) >= 7) {
+ gen7_filter_tiling(dev, info, &tiling_flags);
+ } else {
+ isl_finishme("%s: gen%u", __func__, ISL_DEV_GEN(dev));
+ gen7_filter_tiling(dev, info, &tiling_flags);
}
#define CHOOSE(__tiling) \
--
2.9.0
More information about the mesa-dev
mailing list