[Mesa-dev] [PATCH resend] pipe_loader_sw: Fix fd leak when instantiated via pipe_loader_sw_probe_kms
Hans de Goede
hdegoede at redhat.com
Tue Jun 28 10:31:18 UTC 2016
Hi,
On 27-05-16 16:24, Emil Velikov wrote:
> Hi Hans,
>
> On 27 May 2016 at 15:06, Hans de Goede <hdegoede at redhat.com> wrote:
>> Make pipe_loader_sw_probe_kms take ownership of the passed in fd,
>> like pipe_loader_drm_probe_fd does.
>>
>> The only caller is dri_kms_init_screen which passes in a dupped fd,
>> just like dri2_init_screen passes in a dupped fd to
>> pipe_loader_drm_probe_fd.
>>
> My memory is failing ... I thought I replied to this.
>
> The patch is correct, so
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Thanks, unfortunately I was swamped with other stuff, so I did not
get around until pushing it until now.
It is pushed now.
> I wonder when I'll get the chance to fold the
> almost-but-no-quite-the-same sw and hw side of the pipe loader. If
> you're interested let me know.
Sorry, -ENOTIME.
Regards,
Hans
More information about the mesa-dev
mailing list