[Mesa-dev] [PATCH] gallium: Force blend color to 16-byte alignment

Matt Turner mattst88 at gmail.com
Tue Jun 28 20:51:19 UTC 2016


On Tue, Jun 28, 2016 at 1:45 PM, Chuck Atkins <chuck.atkins at kitware.com> wrote:
> This aligns the 4-element color float array to 16 byte boundaries.  This
> should allow compiler vectorizers to generate better optimizations.
> Also fixes broken vectorization generated by Intel compiler.
>
> Reported-by: Tim Rowley <timothy.o.rowley at intel.com>
> Signed-off-by: Chuck Atkins <chuck.atkins at kitware.com>
> ---
>  src/gallium/include/pipe/p_state.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h
> index 1543e90..95f140f 100644
> --- a/src/gallium/include/pipe/p_state.h
> +++ b/src/gallium/include/pipe/p_state.h
> @@ -326,7 +326,7 @@ struct pipe_blend_state
>
>  struct pipe_blend_color
>  {
> -   float color[4];
> +  PIPE_ALIGN_VAR(16) float color[4];

Looks like you lost a space of indentation. Whoever commits, please fix.


More information about the mesa-dev mailing list