[Mesa-dev] [PATCH] i965: Use drmIoctl for DRM_I915_GETPARAM (v2)
Chad Versace
chad.versace at intel.com
Wed Jun 29 16:50:36 UTC 2016
Stop using drmCommandWriteRead for such a simple ioctl.
v2: Handle errno correctly. [ickle]
---
src/mesa/drivers/dri/i965/intel_screen.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c
index f724a56..1c71e09 100644
--- a/src/mesa/drivers/dri/i965/intel_screen.c
+++ b/src/mesa/drivers/dri/i965/intel_screen.c
@@ -972,17 +972,18 @@ static const __DRIextension *intelRobustScreenExtensions[] = {
static int
intel_get_param(struct intel_screen *screen, int param, int *value)
{
- int ret;
+ int ret = 0;
struct drm_i915_getparam gp;
memset(&gp, 0, sizeof(gp));
gp.param = param;
gp.value = value;
- ret = drmCommandWriteRead(screen->driScrnPriv->fd,
- DRM_I915_GETPARAM, &gp, sizeof(gp));
- if (ret < 0 && ret != -EINVAL)
- _mesa_warning(NULL, "drm_i915_getparam: %d", ret);
+ if (drmIoctl(screen->driScrnPriv->fd, DRM_IOCTL_I915_GETPARAM, &gp) == -1) {
+ ret = -errno;
+ if (ret != -EINVAL)
+ _mesa_warning(NULL, "drm_i915_getparam: %d", ret);
+ }
return ret;
}
--
2.9.0.rc2
More information about the mesa-dev
mailing list