[Mesa-dev] [PATCH v2 08/34] isl: Add an auxiliary surface layout enum

[Chad Versace]

On Thu 23 Jun 2016, Jason Ekstrand wrote:
> ---
>  src/intel/isl/isl.h | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
> index 4aedb11..5011d15 100644
> --- a/src/intel/isl/isl.h
> +++ b/src/intel/isl/isl.h
> @@ -506,6 +506,32 @@ enum isl_dim_layout {
>     ISL_DIM_LAYOUT_GEN9_1D,
>  };
>  
> +enum isl_aux_layout {
> +   /** No Auxiliary surface is used */
             ^^^
             lowercase 'a'

> +   ISL_AUX_LAYOUT_NONE,
> +
> +   /** The primary surface is a depth surface and the auxiliary surface is HiZ */
> +   ISL_AUX_LAYOUT_HIZ,
> +
> +   /** The auxiliary surface is an MCS
> +    *
> +    * @invariant isl_surf::samples > 1
> +    */
> +   ISL_AUX_LAYOUT_MCS,
> +
> +   /** The auxiliary surface is a fast-clear-only compression surface
> +    *
> +    * @invariant isl_surf::samples == 1
> +    */
> +   ISL_AUX_LAYOUT_CCS_D,
> +
> +   /** The auxiliary surface provides full lossless color compression
> +    *
> +    * @invariant isl_surf::samples == 1
> +    */
> +   ISL_AUX_LAYOUT_CCS_E,
> +};

On Monday, we discussed changing this to

    enum isl_aux_usage {
       ISL_AUX_USAGE_NONE,
       ISL_AUX_USAGE_HIZ,
       ISL_AUX_USAGE_MCS,
       ISL_AUX_USAGE_CCS_D,
       ISL_AUX_USAGE_CCS_E,
     };

because the enum doesn't really specify "layout"; it specifies "usage".
For example, on any given gen, the layout of ccs_d and ccs_e is
identical.