[Mesa-dev] [PATCH] glsl: Add function parameters to the parser symbol table.
Timothy Arceri
t_arceri at yahoo.com.au
Sat Mar 5 06:50:41 UTC 2016
On Fri, 2016-03-04 at 22:30 -0800, Kenneth Graunke wrote:
> In a shader such as:
>
> struct S { float f; }
> float identity(float S) { return S; }
>
> we would think that "S" in "return S" referred to a structure, even
> though it's shadowed by the "float S" parameter in the inner struct.
>
> This led to the parser's grammar seeing TYPE_IDENTIFIER and getting
> confused.
>
> Fixes dEQP-GLES2.functional.shaders.scoping.valid.
> function_parameter_hides_struct_type_{vertex,fragment}.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>
More information about the mesa-dev
mailing list