[Mesa-dev] [PATCH] squash: Fix up VPM read optimization.

[Rhys Kidd]

On 13 March 2016 at 17:09, Varad Gautam <varadgautam at gmail.com> wrote:

> - Do not reorder instructions reading packed sources (fixes piglit
> regressions with draw-vertices and draw-vertices-user).
> ---
> Eric, Rhys, with this bit we should be good to go.
>
>  src/gallium/drivers/vc4/vc4_opt_vpm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/vc4/vc4_opt_vpm.c
> b/src/gallium/drivers/vc4/vc4_opt_vpm.c
> index a4ee6af..d15b0c1 100644
> --- a/src/gallium/drivers/vc4/vc4_opt_vpm.c
> +++ b/src/gallium/drivers/vc4/vc4_opt_vpm.c
> @@ -77,7 +77,8 @@ qir_opt_vpm(struct vc4_compile *c)
>                          continue;
>
>                  for (int j = 0; j < qir_get_op_nsrc(inst->op); j++) {
> -                        if (inst->src[j].file != QFILE_TEMP)
> +                        if (inst->src[j].file != QFILE_TEMP ||
> +                            inst->src[j].pack)
>                                  continue;
>
>                          uint32_t temp = inst->src[j].index;
> --
> 2.6.2
>
>
No piglit regressions, so this gets my

Tested-by: Rhys Kidd <rhyskidd at gmail.com>

This applies to the squashed set of [0], [1], and [2] plus this patch.
Given I believe you do not yet have Mesa commit access, perhaps ask Eric if
he'd commit that set for you.

Thanks for your contribution Varad!

[0] https://patchwork.freedesktop.org/patch/76069/
[1] https://patchwork.freedesktop.org/patch/76070/
[2] https://patchwork.freedesktop.org/patch/76528/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160313/77e0ef1a/attachment.html>