[Mesa-dev] Small changes in GL3.txt

Romain Failliot romain.failliot at foolstep.com
Tue Mar 15 01:12:05 UTC 2016


Thanks for the explanations, I'll resend these patch the right way.

2016-03-14 10:01 GMT-04:00 Nicolai Hähnle <nhaehnle at gmail.com>:
> Hi Romain,
>
> On 13.03.2016 16:50, Romain Failliot wrote:
>>
>> Hi!
>>
>> With the recent commits, I'm having some trouble parsing the GL3.txt
>> text file for mesamatrix.net.
>>
>> With these set of 4 patches, I'm proposing to rationalize a little bit
>> this file. The content is exactly the same.
>> (Note: I'm not really used to propose patches, so if this format is
>> wrong, I'll be glad to do it the proper way)
>
>
> It would be great if you provided git commit messages for your patches, and
> provide them in a format that is easily consumed by git. The explanations in
> your email are a good basis for such git commit messages.
>
> To produce properly formatted patches, the nicest path is via git
> send-email, since it directly produces emails with inline patches. The
> second best option (which requires less setup on your behalf) is to attach
> patches produced with git format-patch. This is harder to review, but it
> does preserve all the relevant git metadata.
>
> Apart from that, the patches look fine to me. mesamatrix.net is a useful
> service, let's help keep it running :)
>
> Cheers,
> Nicolai
>
>>
>> # gl3_txt_1_howto.patch
>> Add some explanations on how to read (and edit) GL3.txt.
>> It tends to give some sort of easy to follow standard.
>>
>> # gl3_txt_2_realign_status.patch
>> Realign the Status column to the same column number.
>>
>> # gl3_txt_3_renormalize_some_extensions.patch
>> The comment for GL_ARB_texture_buffer_object was between "DONE" and
>> the brackets, it's an exception compared to the way it's done for
>> other extensions.
>> The status of GL_KHR_robustness was "90% done", it is now "in
>> progress" and "90% done" is in the extension comment.
>>
>> # gl3_txt_4_renormalize_older_extensions.patch
>> On older extensions, there is an explanation first and the extension
>> name in brackets. I inverted that so we have the extension first and
>> then the explanation in brackets (it will help me later for the "all
>> drivers that support <GL_extension>").
>>
>> I might have more patches later, but I'd like to see if these are OK
>> for you first.
>>
>> Cheers!
>> Romain
>>
>>
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
>


More information about the mesa-dev mailing list