[Mesa-dev] [PATCH] mesa: Ignore glPointSize when GL_POINT_SIZE_ARRAY_OES is enabled

[Kenneth Graunke]

On Tuesday, March 15, 2016 8:39:49 PM PDT Plamena Manolova wrote:
> When a user defines a point size array and enables it, the point
> size value set via glPointSize should be ignored. To achieve this,
> we can simply omit point size when creating a batch inside
> upload_sf_state for brw, gen6, gen7 and gen8.

I've made one small change to the commit message so it matches the
updated code:

"we can simply toggle ctx->VertexProgram.PointSizeEnabled."
(instead of the last two lines)

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Pushed.  Thanks again!

> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42187
> Signed-off-by: Plamena Manolova <plamena.manolova at intel.com>
> ---
>  src/mesa/main/enable.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c
> index 3985457..b90a60b 100644
> --- a/src/mesa/main/enable.c
> +++ b/src/mesa/main/enable.c
> @@ -105,6 +105,8 @@ client_state(struct gl_context *ctx, GLenum cap, 
GLboolean state)
>        case GL_POINT_SIZE_ARRAY_OES:
>           var = &vao->VertexAttrib[VERT_ATTRIB_POINT_SIZE].Enabled;
>           flag = VERT_BIT_POINT_SIZE;
> +         FLUSH_VERTICES(ctx, _NEW_PROGRAM);
> +         ctx->VertexProgram.PointSizeEnabled = state;
>           break;
>  
>        /* GL_NV_primitive_restart */
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160315/ae4588cc/attachment.sig>