[Mesa-dev] [PATCH 12/17] gallium/util: Ensure util_framebuffer_get_num_samples() is valid

Marek Olšák maraeo at gmail.com
Mon Mar 21 15:49:52 UTC 2016


On Sat, Mar 19, 2016 at 6:07 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> Normally samples == 0 is perfecly valid and means "not multisampling".
> Why is it invalid here?

Because this function never returns 0 and drivers depend on that
behavior. The patch looks good:

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

I would just prefer it if the patch used "NOTE:" instead of "N.B.".

Marek


More information about the mesa-dev mailing list