[Mesa-dev] [PATCH 12/17] gallium/util: Ensure util_framebuffer_get_num_samples() is valid

Ilia Mirkin imirkin at alum.mit.edu
Mon Mar 21 16:14:21 UTC 2016


On Mon, Mar 21, 2016 at 11:49 AM, Marek Olšák <maraeo at gmail.com> wrote:
> On Sat, Mar 19, 2016 at 6:07 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> Normally samples == 0 is perfecly valid and means "not multisampling".
>> Why is it invalid here?
>
> Because this function never returns 0 and drivers depend on that
> behavior. The patch looks good:

Ah, indeed. This should then be squashed into the patch which adds the
behaviour in the first place, since that code does not presently exist
in git master.

  -ilia


More information about the mesa-dev mailing list