[Mesa-dev] [PATCH 14/29] nir: add support for printing double immediates

[Jason Ekstrand]

On Mar 23, 2016 2:59 AM, "Samuel Iglesias Gonsálvez" <siglesias at igalia.com>
wrote:
>
>
>
> On 22/03/16 16:17, Samuel Iglesias Gonsálvez wrote:
> > On 21/03/16 23:49, Jason Ekstrand wrote:
> >> On Mon, Mar 21, 2016 at 5:05 AM, Samuel Iglesias Gonsálvez <
> >> siglesias at igalia.com> wrote:
> >>
> >>> From: Connor Abbott <connor.w.abbott at intel.com>
> >>>
> >>> ---
> >>>  src/compiler/nir/nir_print.c | 5 ++++-
> >>>  1 file changed, 4 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/src/compiler/nir/nir_print.c
b/src/compiler/nir/nir_print.c
> >>> index 30a8233..0b3f954 100644
> >>> --- a/src/compiler/nir/nir_print.c
> >>> +++ b/src/compiler/nir/nir_print.c
> >>> @@ -719,7 +719,10 @@ print_load_const_instr(nir_load_const_instr
*instr,
> >>> print_state *state)
> >>>         * and then print the float in a comment for readability.
> >>>         */
> >>>
> >>> -      fprintf(fp, "0x%08x /* %f */", instr->value.u32[i],
> >>> instr->value.f32[i]);
> >>> +      if (instr->def.bit_size == 64)
> >>> +         fprintf(fp, "%f", instr->value.f64[i]);
> >>>
> >>
> >> Let's print out the 64-bit integer here as well.  64-bit integer
support
> >> may happen.
> >>
> >
> > OK, I will do the change.
> >
> > Sam
> >
>
> Looking at this patch and the other two nir/print patches, it makes
> sense to squash them altogether in one patch. Is it OK for you?

Yup. Sounds good

> Sam
>
> >>
> >>> +      else
> >>> +         fprintf(fp, "0x%08x /* %f */", instr->value.u32[i],
> >>> instr->value.f32[i]);
> >>>     }
> >>>
> >>>     fprintf(fp, ")");
> >>> --
> >>> 2.5.0
> >>>
> >>> _______________________________________________
> >>> mesa-dev mailing list
> >>> mesa-dev at lists.freedesktop.org
> >>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >>>
> >>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160323/e252606d/attachment-0001.html>