[Mesa-dev] [PATCH] mesa: allow mutable buffer textures to back GL ES images

[Samuel Pitoiset]

Thanks!

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 03/29/2016 09:31 PM, Ilia Mirkin wrote:
> Since there is no way to create immutable texture buffers in GL ES,
> mutable buffer textures are allowed to back images. See issue 7 of the
> GL_OES_texture_buffer specification.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>   src/mesa/main/shaderimage.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c
> index fd5934f..90643c4 100644
> --- a/src/mesa/main/shaderimage.c
> +++ b/src/mesa/main/shaderimage.c
> @@ -583,8 +583,13 @@ _mesa_BindImageTexture(GLuint unit, GLuint texture, GLint level,
>          *
>          * "An INVALID_OPERATION error is generated if texture is not the name
>          *  of an immutable texture object."
> +       *
> +       * However note that issue 7 of the GL_OES_texture_buffer spec
> +       * recognizes that there is no way to create immutable buffer textures,
> +       * so those are excluded from this requirement.
>          */
> -      if (_mesa_is_gles(ctx) && !t->Immutable) {
> +      if (_mesa_is_gles(ctx) && !t->Immutable &&
> +          t->Target != GL_TEXTURE_BUFFER) {
>            _mesa_error(ctx, GL_INVALID_OPERATION,
>                        "glBindImageTexture(!immutable)");
>            return;
>