[Mesa-dev] [PATCH] st/nine: clean up WINAPI definition

Emil Velikov emil.l.velikov at gmail.com
Sun May 1 10:02:14 UTC 2016

Hi Christian,

On 29 April 2016 at 19:53, Christian Schmidbauer
<ch.schmidbauer at gmail.com> wrote:
> As Emil pointed out, only gcc, clang and MSVC compatibility is required.
> Hence the check for GNUC can be skipped, as __i386__ and __x86_64__ are
> only defined for gcc/clang, not for MSVC.
> Remove the #undef which has been there for historic reasons, when wine
> dlls for nine have been built inside mesa. Instead use #ifndef in order
> to avoid redefining WINAPI from MSVC's headers.
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks for picking this up. Should we apply this for stable as well
(considering the patch it 'fixes' is already in there) ?
I'm slightly concerned about the removal of undef WINAPI - I take it
that you've tested the patch ?

Humbly waiting for an ack/r-b/t-b from someone (else) involved in Nine ;-)


More information about the mesa-dev mailing list